Use rctx.name if rctx.original_name is empty
#1702
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works around breakages when building under `WORKSPACE` with Bazel 8.1.0, as described in bazelbuild/bazel#25286. Part of bazel-contrib#1652. PR bazel-contrib#1694 added support for `rctx.original_name` after the implementation of bazelbuild/bazel#24467 landed in 8.1.0rc2. However, I hadn't tested `WORKSPACE` builds with 8.1.0rc2 before 8.1.0 came out. This resolves the breakage until a Bazel 8 release containing a fix for bazelbuild/bazel#25286 becomes available (possibly Bazel 8.2.0).
simuons
approved these changes
Feb 18, 2025
|
Thanks, @simuons! Also, it looks like a fix is out (bazelbuild/bazel#25296), and it may make it into Bazel 8.1.1 (bazelbuild/bazel#25302). |
|
Closing this, since I can confirm that Bazel 8.1.1rc1 fixes bazelbuild/bazel#25286. Bazel 8.1.1 should be out well before we publish a version with Bazel 8 compatibility (#1652). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Works around breakages when building under
WORKSPACEwith Bazel 8.1.0, as described in bazelbuild/bazel#25286. Part of #1652.Motivation
PR #1694 added support for
rctx.original_nameafter the implementation of bazelbuild/bazel#24467 landed in 8.1.0rc2. However, I hadn't testedWORKSPACEbuilds with 8.1.0rc2 before 8.1.0 came out.This resolves the breakage until a Bazel 8 release containing a fix for bazelbuild/bazel#25286 becomes available (possibly Bazel 8.2.0).